The agent adds a tone prop to Notice: "info" | "warning" | "danger". The component file is updated. The tests even cover two tones. The Storybook story still only renders the default. The next designer who opens the sidebar has no control to flip, and the docs table does not mention tone.
I’ve started treating a new public prop without a story or control update as an incomplete PR. If the team uses Storybook as the catalog, the catalog is part of the interface. The model should not leave that file for “a follow-up.”
Why the story gets skipped
The prompt said “add a tone prop.” The type and the JSX are the obvious diffs. The story lives in another file, often with args that were generated once and never touched. Agents are conservative about editing “unrelated” files unless you name them.
The result is a prop that exists only for people who already read the type. Design review happens in Storybook. QA happens in Storybook. If the control is missing, the prop is half-shipped.
A simple catalog policy
- New public prop → story args / controls / docgen in the same PR
- Every enum value gets at least one visible state — a control, a named story, or both
- Default stays obvious — do not hide the new prop behind an undocumented combination
- Private props stay private — do not invent a control for an internal flag
If the repo uses CSF3, autodocs, or a argTypes file, tell the agent which pattern to follow. Do not let it add a second story format.
What to put in the prompt
If you add or change a public component prop, update the Storybook story in the same PR:
add the arg, the control, and a short description.
Show each enum value at least once.
Follow the existing CSF pattern in this folder. Do not invent a new story format.
Paste the current story and the component props type together. In review, open the story, not just the diff.
If the prop is a callback (onDismiss, onChange), the story still needs something the reviewer can fire — an action() in args, or a small wrapper story that logs the call. A new required callback with no default in the story will crash the catalog, which is a worse miss than a missing control.
For visual props (tone, size, density), a matrix or a set of named stories is easier to review than a single default with a hidden radio. Pick the pattern the folder already uses. Do not add both a matrix and a new MDX page for one prop.
Reject / send back
Reject
- A new public prop with no story or argTypes change
- A control that only exposes two of four enum values
- A new
.stories.tsxformat that does not match the folder - “Docs can be updated later”
Accept
- The story renders the new prop, with a control or named variants for each public value
- Autodocs picks up the type and description
- A deliberate decision that the prop is internal, with no export of it
Top comments (0)